Remove unreliable test #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The doctest error is fixed in #966. |
Member
|
If we filled the parent with sufficiently random values, the probability that |
nalimilan
reviewed
Jan 5, 2026
| if A isa Union{Symmetric,Hermitian} | ||
| @test fA isa (A isa Symmetric ? Symmetric : Hermitian) | ||
| @test fA.uplo == A.uplo | ||
| @test parent(fA) != fA # only active triangle is written to |
Member
There was a problem hiding this comment.
There's the same line in the branch above, shouldn't it be removed too?
Member
Author
There was a problem hiding this comment.
The test in the branch above should be fine since it's for the in-place methods: In these cases, as tested, fA === A but since A is created by copying (and potentially wrapping) a properly initialised matrix, the parent could only be equal to the wrapped array after the cov2cor!/cor2cov! call if all standard deviations are one.
nalimilan
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation for the test is to check that out-of-place
cov2corandcor2covofHermitianandSymmetricmatrices only write to the active triangle. But it's a bit unreliable (see e.g. https://github.com/JuliaStats/StatsBase.jl/actions/runs/18417193235?pr=965) as we don't have any control over how the output matrix is actually initialized inStatsBase.jl/src/cov.jl
Line 132 in 92d1674
StatsBase.jl/src/cov.jl
Line 195 in 92d1674